dongjoon-hyun commented on a change in pull request #35640:
URL: https://github.com/apache/spark/pull/35640#discussion_r820455668
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/VolcanoFeatureStep.scala
##########
@@ -47,9 +51,25 @@ private[spark] class VolcanoFeatureStep extends
KubernetesDriverCustomFeatureCon
.withName(podGroupName)
.withNamespace(namespace)
.endMetadata()
+ .editOrNewSpec()
+ .withMinMember(MIN_MEMBER)
+ .endSpec()
queue.foreach(podGroup.editOrNewSpec().withQueue(_).endSpec())
+ minCPU.foreach{ cpu =>
+ val cpuQ = new QuantityBuilder(false)
+ .withAmount(s"${cpu}")
Review comment:
It seems that we don't need `{` and `}` .
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/VolcanoFeatureStep.scala
##########
@@ -47,9 +51,25 @@ private[spark] class VolcanoFeatureStep extends
KubernetesDriverCustomFeatureCon
.withName(podGroupName)
.withNamespace(namespace)
.endMetadata()
+ .editOrNewSpec()
+ .withMinMember(MIN_MEMBER)
+ .endSpec()
queue.foreach(podGroup.editOrNewSpec().withQueue(_).endSpec())
+ minCPU.foreach{ cpu =>
+ val cpuQ = new QuantityBuilder(false)
+ .withAmount(s"${cpu}")
+ .build()
+ podGroup.editOrNewSpec().addToMinResources("cpu", cpuQ).endSpec()
+ }
+ minMemory.foreach{ memory =>
+ val memoryQ = new QuantityBuilder(false)
+ .withAmount(s"${memory}")
Review comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
