dongjoon-hyun commented on a change in pull request #35640:
URL: https://github.com/apache/spark/pull/35640#discussion_r820458200
##########
File path:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/VolcanoTestsSuite.scala
##########
@@ -190,7 +196,58 @@ private[spark] trait VolcanoTestsSuite extends
BeforeAndAfterEach { k8sSuite: Ku
)
}
- test("SPARK-38188: Run SparkPi jobs with 2 queues (only 1 enabled)",
k8sTestTag, volcanoTag) {
+ private def verifyJobsSucceededOneByOne(jobNum: Int, groupName: String):
Unit = {
+ // Check Pending jobs completed one by one
+ (1 until jobNum).map { completedNum =>
+ Eventually.eventually(TIMEOUT, INTERVAL) {
+ val pendingPods = getPods(role = "driver", groupName, statusPhase =
"Pending")
+ assert(pendingPods.size === jobNum - completedNum)
+ }
+ }
+ // All jobs succeeded finally
+ Eventually.eventually(TIMEOUT, INTERVAL) {
+ val succeededPods = getPods(role = "driver", groupName, statusPhase =
"Succeeded")
+ assert(succeededPods.size === jobNum)
+ }
+ }
+
+ test("SPARK-38187: Run SparkPi Jobs with minCPU", k8sTestTag, volcanoTag) {
+ val groupName = generateGroupName("min-cpu")
+ // Create a queue with 2 CPU, 3G memory capacity
+ createOrReplaceYAMLResource(QUEUE_2U_3G_YAML)
+ // Submit 3 jobs with minCPU = 2
+ val jobNum = 3
+ (1 to jobNum).map { i =>
+ Future {
+ runJobAndVerify(
+ i.toString,
+ groupLoc = Option(groupName),
+ queue = Option("queue-2u-3g"),
+ minCPU = Option("2"))
+ }
+ }
+ verifyJobsSucceededOneByOne(jobNum, groupName)
+ }
+
+ test("SPARK-38187: Run SparkPi Jobs with minMemory", k8sTestTag, volcanoTag)
{
+ val groupName = generateGroupName("min-mem")
+ // Create a queue with 2 CPU, 3G memory capacity
+ createOrReplaceYAMLResource(QUEUE_2U_3G_YAML)
+ // Submit 3 jobs with minMemory = 3g
+ val jobNum = 3
+ (1 to jobNum).map { i =>
+ Future {
+ runJobAndVerify(
+ i.toString,
+ queue = Option("queue-2u-3g"),
+ groupLoc = Option(groupName),
+ minMemory = Option("3g"))
+ }
+ }
+ verifyJobsSucceededOneByOne(jobNum, groupName)
+ }
+
+ test("SPARK-38188: Run SparkPi jobs with 2 queues (only 1 enable)",
k8sTestTag, volcanoTag) {
Review comment:
This looks like reverting to the original typo, `enable`. Could you
recheck this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
