beliefer commented on a change in pull request #35727:
URL: https://github.com/apache/spark/pull/35727#discussion_r820510077
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -54,23 +53,17 @@ import org.apache.spark.util.NextIterator
* Util functions for JDBC tables.
*/
object JdbcUtils extends Logging with SQLConfHelper {
+
/**
* Returns a factory for creating connections to the given JDBC URL.
*
* @param options - JDBC options that contains url, table and other
information.
* @throws IllegalArgumentException if the driver could not open a JDBC
connection.
*/
def createConnectionFactory(options: JDBCOptions): () => Connection = {
Review comment:
Could we dependent `SparkConf` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
