stczwd commented on a change in pull request #35669:
URL: https://github.com/apache/spark/pull/35669#discussion_r821302841



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
##########
@@ -2053,6 +2053,34 @@ class ParquetV2FilterSuite extends ParquetFilterSuite {
       }
     }
   }
+
+  test("SPARK-38041: Data filter push down with partition filter") {
+    val data = spark.createDataFrame((1 to 4).map(i => Tuple1(Option(i))))
+    withNestedDataFrame(data).foreach { case (inputDF, colName, resultFun) =>
+      withTempPath { file =>
+
+        val partName = "part"
+        inputDF.withColumn(partName, lit(0))

Review comment:
       Ah, I miss the `.partitionBy(partName)`, I will add it in next commit.

##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
##########
@@ -2053,6 +2053,34 @@ class ParquetV2FilterSuite extends ParquetFilterSuite {
       }
     }
   }
+
+  test("SPARK-38041: Data filter push down with partition filter") {
+    val data = spark.createDataFrame((1 to 4).map(i => Tuple1(Option(i))))
+    withNestedDataFrame(data).foreach { case (inputDF, colName, resultFun) =>

Review comment:
       Agreed. I will remove this in next commit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to