LuciferYang commented on pull request #35669:
URL: https://github.com/apache/spark/pull/35669#issuecomment-1061444419


   Should `(id > 0 AND p = 0) OR (id = 2 AND p = 1)`  really be optimized to
   
   ```
   == Physical Plan ==
   *(1) Filter ((id#9L > 0) OR (id#9L = 2))
   +- *(1) ColumnarToRow
      +- BatchScan[id#9L, p#10] ParquetScan DataFilters: [((id#9L > 0) OR 
(id#9L = 2))], Format: parquet, Location: InMemoryFileIndex(1 
paths)[file:/private/var/folders/pt/_5f4sxy56x70dv9zpz032f0m0000gn/T/spark-38...,
 PartitionFilters: [((p#10 = 0) OR (p#10 = 1))], PushedAggregation: [], 
PushedFilters: [Or(GreaterThan(id,0),EqualTo(id,2))], PushedGroupBy: [], 
ReadSchema: struct<id:bigint>, PushedFilters: 
[Or(GreaterThan(id,0),EqualTo(id,2))], PushedAggregation: [], PushedGroupBy: [] 
RuntimeFilters: []
   ```
   
   It looks wrong for record `id=1, p=1`, or did I get it wrong @huaxingao?
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to