huaxingao commented on a change in pull request #35669:
URL: https://github.com/apache/spark/pull/35669#discussion_r824323846
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
##########
@@ -617,6 +623,10 @@ class ParquetFilters(
nameToParquetField.contains(name) && valueCanMakeFilterOn(name, value)
}
+ private def canMakeFilterOnPart(filter: sources.Filter): Boolean = {
Review comment:
Seems to me this method name is a bit misleading. We are not really
making a Parquet Filter for this partition filter and push it down to Parquet.
It might be better to call it something like
`canDynamicallyPushDownDataFilter`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
