sunchao commented on a change in pull request #35657:
URL: https://github.com/apache/spark/pull/35657#discussion_r827164003
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
##########
@@ -137,8 +138,16 @@ case class EnsureRequirements(
Some(finalCandidateSpecs.values.maxBy(_.numPartitions))
}
+ // Check if 1) all children are of `DataSourcePartitioning` and 2) they
are all compatible
+ // with each other. If both are true, skip shuffle.
+ val allCompatible = childrenIndexes.sliding(2).map {
+ case Seq(a, b) =>
+ checkDataSourceSpec(specs(a)) && checkDataSourceSpec(specs(b)) &&
+ specs(a).isCompatibleWith(specs(b))
+ }.forall(_ == true)
+
children = children.zip(requiredChildDistributions).zipWithIndex.map {
- case ((child, _), idx) if !childrenIndexes.contains(idx) =>
+ case ((child, _), idx) if allCompatible ||
!childrenIndexes.contains(idx) =>
Review comment:
This is because we don't allow Spark to re-shuffle the other side of the
join using `DataSourceShuffleSpec` yet, so its `canCreatePartitioning` is
false. However, we do want to skip shuffle the if all sides of a join all have
compatible `DataSourceShuffleSpec`, and so there is a special check here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
