sunchao commented on a change in pull request #35657: URL: https://github.com/apache/spark/pull/35657#discussion_r828276136
########## File path: sql/catalyst/src/main/scala-2.12/org/apache/spark/sql/catalyst/util/InternalRowSet.scala ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.util + +import scala.collection.mutable + +import org.apache.spark.sql.catalyst.InternalRow +import org.apache.spark.sql.catalyst.expressions.{Murmur3HashFunction, RowOrdering} +import org.apache.spark.sql.types.{DataType, StructField, StructType} + +/** + * A mutable Set with [[InternalRow]] as its element type. It uses Spark's internal murmur hash to + * compute hash code from an row, and uses [[RowOrdering]] to perform equality checks. + * + * @param dataTypes the data types for the row keys this set holds + */ +class InternalRowSet(val dataTypes: Seq[DataType]) extends mutable.Set[InternalRow] { Review comment: I'm following existing classes like `AttributeSet` here. Plus this makes it more useful if Spark needs to use it in somewhere else in future? there are many functions you get it for free from `mutable.Set`, such as `map`, `foreach`, `filter` as well as overloaded operators. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
