mridulm commented on a change in pull request #35852:
URL: https://github.com/apache/spark/pull/35852#discussion_r827341070
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
##########
@@ -639,7 +643,7 @@ object ScalaReflection extends ScalaReflection {
def getConstructorParameters(cls: Class[_]): Seq[(String, Type)] = {
val m = runtimeMirror(cls.getClassLoader)
val classSymbol = m.staticClass(cls.getName)
- val t = classSymbol.selfType
+ val t = selfType(classSymbol)
Review comment:
Is this limited only to `selfType` ?
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
##########
@@ -653,10 +657,37 @@ object ScalaReflection extends ScalaReflection {
def getConstructorParameterNames(cls: Class[_]): Seq[String] = {
val m = runtimeMirror(cls.getClassLoader)
val classSymbol = m.staticClass(cls.getName)
- val t = classSymbol.selfType
+ val t = selfType(classSymbol)
constructParams(t).map(_.name.decodedName.toString)
}
+ /**
+ * Workaround for [[https://github.com/scala/bug/issues/12190 Scala bug
#12190]]
+ *
+ * `ClassSymbol.selfType` can throw an exception in case of cyclic
annotation reference
+ * in Java classes. A retry of this operation will succeed as the class
which defines the
+ * cycle is now resolved. It can however expose further recursive annotation
references, so
+ * we keep retrying until we exhaust our retry threshold.
+ */
+ @tailrec
+ private def selfType(clsSymbol: ClassSymbol, tries: Int = 5): Type = {
Review comment:
Update comment on why `5` ? (essentially `> 1` I guess is what we need
?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
