shardulm94 commented on a change in pull request #35852:
URL: https://github.com/apache/spark/pull/35852#discussion_r827486338



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
##########
@@ -639,7 +643,7 @@ object ScalaReflection extends ScalaReflection {
   def getConstructorParameters(cls: Class[_]): Seq[(String, Type)] = {
     val m = runtimeMirror(cls.getClassLoader)
     val classSymbol = m.staticClass(cls.getName)
-    val t = classSymbol.selfType
+    val t = selfType(classSymbol)

Review comment:
       Unfortunately, I do not have the technical knowhow to answer this 
question. What I can say is that `ScalaReflection` also uses 
`ClassSymbol.companion` which seems to work fine in this case. 
`ClassSymbol.annotations` fails, as might be expected, but it is not used 
anywhere in this class.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to