srowen commented on a change in pull request #35763:
URL: https://github.com/apache/spark/pull/35763#discussion_r828428242
##########
File path: dev/create-release/release-build.sh
##########
@@ -341,8 +341,8 @@ if [[ "$1" == "package" ]]; then
fi
if [[ $PUBLISH_SCALA_2_12 = 1 ]]; then
- echo "Packages to build: ${!BINARY_PKGS_ARGS[@]}"
- for key in ${!BINARY_PKGS_ARGS[@]}; do
+ echo "Packages to build: ${!BINARY_PKGS_ARGS[*]}"
+ for key in "${!BINARY_PKGS_ARGS[@]}"; do
Review comment:
The case it's worried about isn't applicable here. I'm trying to reason
about whether this breaks something by re-quoting the space-separated args.
Maybe not. It's hard to test some of these but I am kind of nervous about these
changes to the release script especially that we won't find problems with until
release time. Maybe we can be more conservative and only make changes if we're
clear it fixes a potential problem, otherwise suppress
##########
File path: dev/make-distribution.sh
##########
@@ -123,26 +123,26 @@ fi
if [ ! "$(command -v "$MVN")" ] ; then
echo -e "Could not locate Maven command: '$MVN'."
echo -e "Specify the Maven command with the --mvn flag"
- exit -1;
+ exit 255;
fi
-VERSION=$("$MVN" help:evaluate -Dexpression=project.version $@ \
+VERSION=$("$MVN" help:evaluate -Dexpression=project.version "$@" \
Review comment:
Same, this doesn't seem to apply
##########
File path: dev/create-release/release-build.sh
##########
@@ -181,7 +181,7 @@ BASE_PROFILES="-Pmesos -Pyarn -Pkubernetes"
PUBLISH_SCALA_2_13=1
SCALA_2_13_PROFILES="-Pscala-2.13"
-if [[ $SPARK_VERSION < "3.2" ]]; then
+if [ "$(echo $SPARK_VERSION | awk -F "." '{if ($1 <= 3 && $2 < 2) print $1}')"
]; then
Review comment:
Hm, nothing here is actually using decimals - it's a lexicographic
comparison. This alternative is less readable, but I also think it's wrong?
"2.4" would not pass this check. We can revert and suppress this warning, or
fix the logic to handle 3.x and <= 2.x possibilities separately in this clause
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
