srowen commented on a change in pull request #35763:
URL: https://github.com/apache/spark/pull/35763#discussion_r830513931
##########
File path:
resource-managers/kubernetes/integration-tests/scripts/setup-integration-test-env.sh
##########
@@ -118,7 +118,7 @@ then
# Build SparkR image
tags=(${EXCLUDE_TAGS//,/ })
- if [[ ! ${tags[@]} =~ "r" ]]; then
+ if [[ ! "${tags[*]}" =~ "r" ]]; then
Review comment:
Yeah I'm even wondering about the original logic - why match a
single-character regular expression? It's probably OK just the one thing I'm
not too sure about. If the behavior _should_ be unchanged - concatenates the
string - then probably OK. I wonder if the person meant to write "if one of the
arguments is `"r"`" which is not what this does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
