cloud-fan commented on pull request #35913: URL: https://github.com/apache/spark/pull/35913#issuecomment-1073449695
This maybe not the right place to discuss it, but this PR reminds me of the new overload `def ceil(e: Column, scale: Column)`. Since we only allow literals as the `scale` parameter, shall we make its type `Int` instead of `Column`? cc @sathiyapk @HyukjinKwon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
