cloud-fan commented on a change in pull request #35913:
URL: https://github.com/apache/spark/pull/35913#discussion_r830735572
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -1783,7 +1783,9 @@ object functions {
* @group math_funcs
* @since 1.4.0
*/
- def ceil(e: Column): Column = ceil(e, lit(0))
+ def ceil(e: Column): Column = withExpr {
+ UnresolvedFunction(Seq("ceil"), Seq(e.expr), isDistinct = false)
Review comment:
To confirm, the problem you hit is: `ceil(input)` and `ceil(input, 0)`
return the same result, but use different expressions which break some custom
catalyst rules?
If that's the case, I'd suggest we also fix `CeilFloorExpressionBuilderBase`
and call `buildWithOneParam` if the `scale` is 0, to make `ceil(input)` and
`ceil(input, 0)` exactly the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
