cloud-fan commented on a change in pull request #35768:
URL: https://github.com/apache/spark/pull/35768#discussion_r830758926
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
##########
@@ -103,12 +123,45 @@ protected String visitIsNotNull(String v) {
return v + " IS NOT NULL";
}
+ protected String visitStringPredicate(String name, GeneralScalarExpression
strPredicate) {
Review comment:
Ideally this should take `String` as inputs, like other `visitXXX`
methods. But this method needs to patter match the predicate name and call
`visitUnexpectedExpr`, which makes it a bit hard to take string input directly.
One proposal is to have 3 visit methods: `visitStartsWith` and so on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
