cloud-fan commented on a change in pull request #35768:
URL: https://github.com/apache/spark/pull/35768#discussion_r830985321
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
##########
@@ -103,12 +125,40 @@ protected String visitIsNotNull(String v) {
return v + " IS NOT NULL";
}
+ protected String visitStartsWith(String l, String r) {
+ String value = r.replaceAll("'", "");
+ return l + " LIKE '" + value + "%'";
+ }
+
+ protected String visitEndsWith(String l, String r) {
+ String value = r.replaceAll("'", "");
Review comment:
what if the string value really contains `'`? I think we should be more
explicit here: `r.substring(1, r.length - 1)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
