wangyum commented on a change in pull request #35878:
URL: https://github.com/apache/spark/pull/35878#discussion_r833250853



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
##########
@@ -1528,6 +1528,55 @@ abstract class DynamicPartitionPruningSuiteBase
       }
     }
   }
+
+  test("SPARK-38570: Fix incorrect DynamicPartitionPruning caused by Literal") 
{
+    withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED.key -> "true") {
+      withTable("fact1", "fact2", "dim") {

Review comment:
       We already have lots of built-in tables. Cloud we change the test query 
to:
   ```sql
   SELECT f.store_id,
          f.date_id,
          s.state_province
   FROM   (SELECT 4 AS store_id,
                  date_id,
                  product_id
           FROM   fact_sk
           WHERE  date_id >= 1300
           UNION ALL
           SELECT 5 AS store_id,
                  date_id,
                  product_id
           FROM   fact_stats
           WHERE  date_id <= 1000) f
          JOIN dim_store s
            ON f.store_id = s.store_id
   WHERE  s.country = 'US'
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to