LuciferYang commented on a change in pull request #35979:
URL: https://github.com/apache/spark/pull/35979#discussion_r835899221
##########
File path:
core/src/test/scala/org/apache/spark/deploy/history/EventLogFileCompactorSuite.scala
##########
@@ -119,7 +119,7 @@ class EventLogFileCompactorSuite extends SparkFunSuite {
withTempDir { dir =>
val fs = new Path(dir.getAbsolutePath).getFileSystem(hadoopConf)
- val fileStatuses = writeEventsToRollingWriter(fs, "app", dir, sparkConf,
hadoopConf,
+ val fileStatuses = writeEventsToRollingWriter(fs, "app a", dir,
sparkConf, hadoopConf,
Review comment:
On second thought, I think in the production environment, illegal
characters(such as %) may appear in `basedir`, maybe we can add a new case as
follows:
```scala
test("SPARK-38664: ${Test display name}") {
// create a base dir with illegal characters
val dir = Utils.createTempDir("spark-%")
try {
// do test
} finally {
Utils.deleteRecursively(dir)
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
