LuciferYang commented on a change in pull request #35979:
URL: https://github.com/apache/spark/pull/35979#discussion_r836021224



##########
File path: 
core/src/test/scala/org/apache/spark/deploy/history/EventLogFileCompactorSuite.scala
##########
@@ -284,6 +286,20 @@ class EventLogFileCompactorSuite extends SparkFunSuite {
     }
   }
 
+  test("SPARK-38664: Support compact EventLog when there are illegal 
characters in the path") {
+    withTempDir { dir =>

Review comment:
       If you still want to use `withTempDir`, you need to refactor 
`withTempDir` to accept `namePrefix`(but this will involve many file changes). 
   
   At present, two `tmpdirs` are created in this way... which is not necessary
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to