martin-g commented on a change in pull request #35976:
URL: https://github.com/apache/spark/pull/35976#discussion_r839906513



##########
File path: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/EncoderResolutionSuite.scala
##########
@@ -200,28 +200,29 @@ class EncoderResolutionSuite extends PlanTest {
 
   test("nested case class can have different number of fields from the real 
schema") {
     val encoder = ExpressionEncoder[(String, StringIntClass)]
-    val attrs = Seq('a.string, 'b.struct('a.string, 'b.int, 'c.int))
+    val attrs = Seq($"a".string, $"b".struct($"a".string, $"b".int, $"c".int))
     encoder.resolveAndBind(attrs)
   }
 
   test("SPARK-28497: complex type is not compatible with string encoder 
schema") {
     val encoder = ExpressionEncoder[String]
 
-    Seq('a.struct('x.long), 'a.array(StringType), 'a.map(StringType, 
StringType)).foreach { attr =>
-      val attrs = Seq(attr)
-      
assert(intercept[AnalysisException](encoder.resolveAndBind(attrs)).message ==
+    Seq($"a".struct($"x".long), $"a".array(StringType), 
Symbol("a").map(StringType, StringType))

Review comment:
       It seems some implicit is missing. I had to revert from `$"a".map(...)` 
to `Symbol("a").map(...)` to be able to compile.
   If you/someone knows the missing implicit please let me know and I will 
rework it!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to