awdavidson commented on pull request #35976: URL: https://github.com/apache/spark/pull/35976#issuecomment-1085476357
I echo @srowen pretty big change but generally looking ok. Let’s address test failure Not to increase the scope of this change but a follow up could be to add a scalastyle check warning against the use of `‘foo` declaration mainly to avoid it being reintroduced going forward? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
