MaxGekk commented on code in PR #35897:
URL: https://github.com/apache/spark/pull/35897#discussion_r841757986
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TryEval.scala:
##########
@@ -181,3 +181,36 @@ case class TryMultiply(left: Expression, right:
Expression, replacement: Express
override protected def withNewChildInternal(newChild: Expression):
Expression =
this.copy(replacement = newChild)
}
+
+/**
+ * Converts the input expression to a binary value based on the supplied
format.
Review Comment:
This comment is not needed since it duplicates the description below.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TryEval.scala:
##########
@@ -181,3 +181,36 @@ case class TryMultiply(left: Expression, right:
Expression, replacement: Express
override protected def withNewChildInternal(newChild: Expression):
Expression =
this.copy(replacement = newChild)
}
+
+/**
+ * Converts the input expression to a binary value based on the supplied
format.
+ * The result is NULL on encoding error.
Review Comment:
It would be better to adjust the expression description about the behaviour
if it is needed.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TryEval.scala:
##########
@@ -181,3 +181,36 @@ case class TryMultiply(left: Expression, right:
Expression, replacement: Express
override protected def withNewChildInternal(newChild: Expression):
Expression =
this.copy(replacement = newChild)
}
+
+/**
+ * Converts the input expression to a binary value based on the supplied
format.
+ * The result is NULL on encoding error.
+ */
+// scalastyle:off line.size.limit
Review Comment:
Is it really needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
