MaxGekk commented on code in PR #35897:
URL: https://github.com/apache/spark/pull/35897#discussion_r843675452
##########
sql/core/src/test/resources/sql-tests/results/string-functions.sql.out:
##########
@@ -1136,3 +1136,12 @@ struct<>
-- !query output
org.apache.spark.sql.AnalysisException
Invalid value for the 'format' parameter of function 'to_binary':
invalidformat. The value has to be a case-insensitive string literal of 'hex',
'utf-8', or 'base64'.
+
+
+-- !query
+select to_binary('a!', 'base64')
+-- !query schema
+struct<>
+-- !query output
+java.lang.IllegalArgumentException
Review Comment:
We should migrate this on Spark's exception. Do we have a ticket for that?
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:
##########
@@ -62,6 +62,9 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession
with AdaptiveSpark
setupTestData()
+ test("foo") {
+ sql("select try_to_binary('abc', 'utf-8')").show()
+ }
Review Comment:
What does it test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
