HeartSaVioR commented on code in PR #36090:
URL: https://github.com/apache/spark/pull/36090#discussion_r844569938
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManagerSuite.scala:
##########
@@ -236,10 +297,16 @@ class SymmetricHashJoinStateManagerSuite extends
StreamTest with BeforeAndAfter
def withJoinStateManager(
inputValueAttribs: Seq[Attribute],
joinKeyExprs: Seq[Expression],
- stateFormatVersion: Int)(f: SymmetricHashJoinStateManager => Unit): Unit =
{
+ stateFormatVersion: Int,
+ skipNullsForStreamStreamJoins: Boolean = false)
+ (f: SymmetricHashJoinStateManager => Unit): Unit = {
withTempDir { file =>
- val storeConf = new StateStoreConf()
+ val sqlConf = new SQLConf
Review Comment:
We have a convenient tool `withSQLConf` dealing with this.
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManagerSuite.scala:
##########
@@ -236,10 +297,16 @@ class SymmetricHashJoinStateManagerSuite extends
StreamTest with BeforeAndAfter
def withJoinStateManager(
inputValueAttribs: Seq[Attribute],
joinKeyExprs: Seq[Expression],
- stateFormatVersion: Int)(f: SymmetricHashJoinStateManager => Unit): Unit =
{
+ stateFormatVersion: Int,
+ skipNullsForStreamStreamJoins: Boolean = false)
+ (f: SymmetricHashJoinStateManager => Unit): Unit = {
Review Comment:
nit: This doesn't seem to be right indentation (honestly all parameters are
incorrect - they should have 4 spaces -, but it was broken already so it's your
call to fix them altogether) but not sure we have a case in Scala style guide.
Probably seeking the existing codebase may give an answer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
