HeartSaVioR commented on code in PR #36090:
URL: https://github.com/apache/spark/pull/36090#discussion_r844779216
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManagerSuite.scala:
##########
@@ -293,28 +292,26 @@ class SymmetricHashJoinStateManagerSuite extends
StreamTest with BeforeAndAfter
manager.metrics.numKeys
}
-
def withJoinStateManager(
- inputValueAttribs: Seq[Attribute],
- joinKeyExprs: Seq[Expression],
- stateFormatVersion: Int,
- skipNullsForStreamStreamJoins: Boolean = false)
- (f: SymmetricHashJoinStateManager => Unit): Unit = {
+ inputValueAttribs: Seq[Attribute],
+ joinKeyExprs: Seq[Expression],
+ stateFormatVersion: Int,
+ skipNullsForStreamStreamJoins: Boolean = false)
+ (f: SymmetricHashJoinStateManager => Unit): Unit = {
withTempDir { file =>
- val sqlConf = new SQLConf
- if (skipNullsForStreamStreamJoins) {
-
sqlConf.setConf(SQLConf.STATE_STORE_SKIP_NULLS_FOR_STREAM_STREAM_JOINS, true)
- }
- val storeConf = new StateStoreConf(sqlConf)
- val stateInfo = StatefulOperatorStateInfo(file.getAbsolutePath,
UUID.randomUUID, 0, 0, 5)
- val manager = new SymmetricHashJoinStateManager(
- LeftSide, inputValueAttribs, joinKeyExprs, Some(stateInfo), storeConf,
new Configuration,
- partitionId = 0, stateFormatVersion)
- try {
- f(manager)
- } finally {
- manager.abortIfNeeded()
+
withSQLConf("spark.sql.streaming.stateStore.skipNullsForStreamStreamJoins.enabled"
->
Review Comment:
last nit: probably better to use
`SQLConf.STATE_STORE_SKIP_NULLS_FOR_STREAM_STREAM_JOINS.key`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
