cloud-fan commented on code in PR #36103:
URL: https://github.com/apache/spark/pull/36103#discussion_r847559090
##########
sql/core/src/test/resources/sql-tests/inputs/string-functions.sql:
##########
@@ -108,6 +111,46 @@ SELECT lpad(x'57', 5, 'abc');
SELECT rpad('abc', 5, x'57');
SELECT rpad(x'57', 5, 'abc');
+-- Dsiable the lpad rpad binary breaking change
Review Comment:
it's probably an overkill to test the flag like this... I think the change
in `StringExpressionsSuite` is good enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
