cloud-fan commented on code in PR #36103:
URL: https://github.com/apache/spark/pull/36103#discussion_r847861774


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -3709,6 +3709,18 @@ object SQLConf {
       .booleanConf
       .createWithDefault(true)
 
+  val LEGACY_LPAD_RPAD_BINARY_TYPE_AS_STRING =
+    buildConf("spark.sql.legacy.lpadRpadBinaryTypeAsString")

Review Comment:
   how about `spark.sql.legacy.lpadRpadAlwaysReturnString`? If true, it's the 
legacy behavior and the pad function always return string even for binary 
inputs. If false, the function returns binary if the first argument and the 
padding pattern parameter are both binary type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to