ulysses-you commented on code in PR #36194:
URL: https://github.com/apache/spark/pull/36194#discussion_r850141489


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AQEShuffleReadExec.scala:
##########
@@ -67,8 +74,7 @@ case class AQEShuffleReadExec private(
             case e: Expression => r.updateAttr(e).asInstanceOf[Partitioning]
             case other => other
           }
-        case _ =>
-          throw new IllegalStateException("operating on canonicalization plan")
+        case _ => super.outputPartitioning

Review Comment:
   it seems overkill to throw error and other canonicalized spark plan can also 
work



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to