cloud-fan commented on code in PR #36194:
URL: https://github.com/apache/spark/pull/36194#discussion_r850237268
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AQEShuffleReadExec.scala:
##########
@@ -48,6 +48,13 @@ case class AQEShuffleReadExec private(
assert(partitionSpecs.forall(_.isInstanceOf[PartialMapperPartitionSpec]))
}
+ private def shuffleStage = child match {
+ case stage: ShuffleQueryStageExec => Some(stage)
+ case _ => None
+ }
+
+ override protected def isCanonicalizedPlan: Boolean = shuffleStage.isEmpty
Review Comment:
what's wrong with the default implementation of `isCanonicalizedPlan`?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AQEShuffleReadExec.scala:
##########
@@ -48,6 +48,13 @@ case class AQEShuffleReadExec private(
assert(partitionSpecs.forall(_.isInstanceOf[PartialMapperPartitionSpec]))
}
+ private def shuffleStage = child match {
+ case stage: ShuffleQueryStageExec => Some(stage)
+ case _ => None
+ }
+
+ override protected def isCanonicalizedPlan: Boolean = shuffleStage.isEmpty
Review Comment:
what's wrong with the default implementation of `isCanonicalizedPlan`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
