cloud-fan commented on PR #36176: URL: https://github.com/apache/spark/pull/36176#issuecomment-1099219884
I did take a look at https://github.com/apache/spark/pull/36174 and I see code like `var ind = words.indexOf("proxy");`. It seems to me that some Spark code assumes "proxy" and "history" are reserved keywords and I'm not sure how many code blocks like this are out there. I don't think it's hard to fix it, but I think it's hard to find all these places that need to fix. In addition, reverse proxy and history server can bring more complexity as @gengliangwang mentioned. To clarify, merging this PR does not mean rejecting the fixing PR. As I said before, this PR actually just improves the error message. You are welcome to continue the fix and find a committer to review it. Unfortunately, I'm not a Spark UI expert and I'm not confident to merge the fix. If you can explain the entire Spark UI stack and how your fix works, I believe it can make it easier for other committers to review the PR and give them more confidence to merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
