PerilousApricot commented on PR #36176: URL: https://github.com/apache/spark/pull/36176#issuecomment-1099241452
Of course, the PR needs to be updated anyway for the cases that [@gengliangwang](https://github.com/gengliangwang) found, I was speaking to not just your comment, but the others as well. To phrase it differently: "I'm going to update the PR, lets judge the complexity based on that" You're critique about indexOf is well taken, and if that's the concern from [@gengliangwang](https://github.com/gengliangwang) and [@dongjoon-hyun](https://github.com/dongjoon-hyun), then I'm glad factorize the fix differently. I've repeatedly tried to emphasize that I'm willing and able to change the code to fit your criteria but, importantly, it's helpful to know what that criteria is. Now that I have your note about indexOf and [@gengliangwang](https://github.com/gengliangwang)'s comment in #36174, I know what you're looking for and can change things accordingly. With respect to.. > To clarify, merging this PR does not mean rejecting the fixing PR ... then I misunderstood the situation, but to me, what I saw was a new PR disabling the functionality without commenting on the previous PR or giving an opportunity to fix the issues beforehand seemed like the door was being slammed on the previous PR. I'll update #31774 with your comments and get back to you. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
