otterc commented on code in PR #36141:
URL: https://github.com/apache/spark/pull/36141#discussion_r850669653
##########
core/src/main/scala/org/apache/spark/shuffle/ShuffleBlockPusher.scala:
##########
@@ -142,7 +142,7 @@ private[spark] class ShuffleBlockPusher(conf: SparkConf)
extends Logging {
* VisibleForTesting
*/
protected def submitTask(task: Runnable): Unit = {
- if (BLOCK_PUSHER_POOL != null) {
+ if (BLOCK_PUSHER_POOL != null && !BLOCK_PUSHER_POOL.isShutdown) {
Review Comment:
So, the reason I am thinking of not bubbling up any type of exceptions from
pusher threads is because:
1. push is best-effort so if there are any exceptions there it should not
interfere with the rest of the executor tasks.
2. the exceptions in these pusher threads can also shutdown executor and
create confusion.
IMO, I think we should just catch and log all the `Throwables` here:
```
private[shuffle] def tryPushUpToMax(): Unit = {
try {
pushUpToMax()
} catch {
case t: Throwable =>
logWarning("There was .... Stopping block push", e)
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
