weixiuli commented on code in PR #36141:
URL: https://github.com/apache/spark/pull/36141#discussion_r851156448
##########
core/src/main/scala/org/apache/spark/shuffle/ShuffleBlockPusher.scala:
##########
@@ -142,7 +142,7 @@ private[spark] class ShuffleBlockPusher(conf: SparkConf)
extends Logging {
* VisibleForTesting
*/
protected def submitTask(task: Runnable): Unit = {
- if (BLOCK_PUSHER_POOL != null) {
+ if (BLOCK_PUSHER_POOL != null && !BLOCK_PUSHER_POOL.isShutdown) {
Review Comment:
> Instead of `Throwable`, let us limit to `NonFatal`
should we cach the exception like that ? @mridulm @otterc
```
private[shuffle] def tryPushUpToMax(): Unit = {
try {
pushUpToMax()
} catch {
case NonFatal(e) =>
logWarning("Failed to tryPushUpToMax", e)
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
