dtenedor commented on PR #36212: URL: https://github.com/apache/spark/pull/36212#issuecomment-1100930838
@morvenhuang apologies for the delay in review, I was on vacation for the last few days :) The changes in `ResolveDefaultColumns` look like they are on the right track. I am thinking, now we have this SQLConf to add NULL values for INSERTs that specify only a subset of the columns, but it is disabled by default. If we want to add functionality based on this, and we think it is useful, let's just enable it by default in this PR. This is safe because it only changes INSERTs that would have returned errors to execute successfully instead. We would need to update the affected tests; this could be done without much work by just pushing a commit setting it to true by default and then let the automated tests run. Then the subset of tests that subsequently fail should indicate what needs to be changed, and the change should be relatively straightforward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
