morvenhuang commented on code in PR #36212:
URL: https://github.com/apache/spark/pull/36212#discussion_r852547368
##########
sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala:
##########
@@ -1078,11 +1101,13 @@ class InsertSuite extends DataSourceTest with
SharedSparkSession {
}
}
// There is one trailing default value referenced implicitly by the INSERT
INTO statement.
- withTable("t") {
- sql("create table t(i int, s bigint default 42, x bigint) using parquet")
- assert(intercept[AnalysisException] {
- sql("insert into t values(1)")
- }.getMessage.contains("expected 3 columns but found"))
+ withSQLConf(SQLConf.USE_NULLS_FOR_MISSING_DEFAULT_COLUMN_VALUES.key ->
"false") {
Review Comment:
Daniel, I see several tests in test("INSERT INTO statements with tables with
default columns: positive tests") already cover this scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
