gengliangwang commented on code in PR #36212:
URL: https://github.com/apache/spark/pull/36212#discussion_r854151629


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -2858,15 +2858,15 @@ object SQLConf {
       .createWithDefault(true)
 
   val USE_NULLS_FOR_MISSING_DEFAULT_COLUMN_VALUES =
-    buildConf("spark.sql.defaultColumn.useNullsForMissingDefautValues")
+    buildConf("spark.sql.defaultColumn.useNullsForMissingDefaultValues")
       .internal()
       .doc("When true, and DEFAULT columns are enabled, allow column 
definitions lacking " +
         "explicit default values to behave as if they had specified DEFAULT 
NULL instead. " +
         "For example, this allows most INSERT INTO statements to specify only 
a prefix of the " +
         "columns in the target table, and the remaining columns will receive 
NULL values.")
       .version("3.4.0")
       .booleanConf
-      .createWithDefault(false)
+      .createWithDefault(true)

Review Comment:
   @dtenedor what should the default value be when this feature is released? I 
am concerned that some existing users are not expecting inserting null values. 
Shall we keep it as `false` and document that users need to enable this 
configuration for inserting views?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to