dtenedor commented on PR #36212:
URL: https://github.com/apache/spark/pull/36212#issuecomment-1102989486

   > @dtenedor Daniel, I realize there're some minor issues, one is that 
DSV2SQLInsertTestSuite: test("insert with column list - mismatched column list 
size") failed when useNullsForMissingDefaultValues=true, this seems due to some 
catalog problem.
   The other one is InsertSuite: test("SPARK-36980: Insert support query with 
CTE"), this test also failed when useNullsForMissingDefaultValues=true.
   These two look pretty tricky to me, and still cannot figure out how to fix 
them, so probably we can just merge the current PR, and then you can help to 
create some new PRs for these issues, your thoughts?
   
   Sure, I can just make a separate PR to update those tests with the 
useNullsForMissingDefaultValues set to both true and false in each test case, 
to verify the behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to