MaxGekk commented on code in PR #36307:
URL: https://github.com/apache/spark/pull/36307#discussion_r857155718
##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryParsingErrorsSuite.scala:
##########
@@ -27,9 +27,10 @@ class QueryParsingErrorsSuite extends QueryTest with
QueryErrorsSuiteBase {
validateParsingError(
sqlText = "SELECT * FROM t1 NATURAL JOIN LATERAL (SELECT c1 + c2 AS c2)",
errorClass = "UNSUPPORTED_FEATURE",
+ errorSubClass = Some("LATERAL_NATURAL_JOIN"),
sqlState = "0A000",
message =
- """The feature is not supported: "LATERAL" join with "NATURAL"
join.(line 1, pos 14)
+ """The feature is not supported: NATURAL join with LATERAL
correlation.(line 1, pos 14)
Review Comment:
In fact, you reverted my recent changes of using double quotes in error
messages: https://github.com/apache/spark/pull/36259. Could you add double
quotes for SQL statements in the json file, please.
You can escape the quotes in the json file like:
```
"UNTYPED_SCALA_UDF" : {
"message" : [ "... set \"spark.sql.legacy.allowUntypedScalaUDF\" to true
..." ]
},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
