MaxGekk commented on code in PR #36307:
URL: https://github.com/apache/spark/pull/36307#discussion_r857166400
##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryParsingErrorsSuite.scala:
##########
@@ -27,9 +27,10 @@ class QueryParsingErrorsSuite extends QueryTest with
QueryErrorsSuiteBase {
validateParsingError(
sqlText = "SELECT * FROM t1 NATURAL JOIN LATERAL (SELECT c1 + c2 AS c2)",
errorClass = "UNSUPPORTED_FEATURE",
+ errorSubClass = Some("LATERAL_NATURAL_JOIN"),
sqlState = "0A000",
message =
- """The feature is not supported: "LATERAL" join with "NATURAL"
join.(line 1, pos 14)
+ """The feature is not supported: NATURAL join with LATERAL
correlation.(line 1, pos 14)
Review Comment:
Users don't care how we form error messages either via passing SQL
statements or by inlining them into templates in the json file. Independently
from the internal mechanism, the output should be consistent I do believe
either to output all SQL statement in double quotes or w/o them everywhere in
error messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
