cloud-fan commented on code in PR #36325:
URL: https://github.com/apache/spark/pull/36325#discussion_r857829301
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala:
##########
@@ -206,14 +213,15 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan]
with PredicateHelper wit
DataSourceV2ScanRelation(sHolder.relation, wrappedScan,
output)
if (r.supportCompletePushDown(pushedAggregates.get)) {
val projectExpressions = finalResultExpressions.map { expr
=>
- // TODO At present, only push down group by attribute is
supported.
- // In future, more attribute conversion is extended
here. e.g. GetStructField
expr.transform {
Review Comment:
let's explicitly use `transformDown` as we need to match an expression tree
for the group by expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
