cloud-fan commented on code in PR #36325:
URL: https://github.com/apache/spark/pull/36325#discussion_r857838506
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala:
##########
@@ -736,11 +736,43 @@ class JDBCV2Suite extends QueryTest with
SharedSparkSession with ExplainSuiteHel
}
test("scan with aggregate push-down: SUM with group by") {
- val df = sql("SELECT SUM(SALARY) FROM h2.test.employee GROUP BY DEPT")
- checkAggregateRemoved(df)
- checkPushedInfo(df, "PushedAggregates: [SUM(SALARY)], " +
+ val df1 = sql("SELECT SUM(SALARY) FROM h2.test.employee GROUP BY DEPT")
+ checkAggregateRemoved(df1)
+ checkPushedInfo(df1, "PushedAggregates: [SUM(SALARY)], " +
"PushedFilters: [], PushedGroupByColumns: [DEPT], ")
- checkAnswer(df, Seq(Row(19000), Row(22000), Row(12000)))
+ checkAnswer(df1, Seq(Row(19000), Row(22000), Row(12000)))
+
+ val df2 = sql(
+ """
+ |SELECT CASE WHEN SALARY > 8000 AND SALARY < 10000 THEN SALARY ELSE 0
END as key,
Review Comment:
is it a valid SQL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
