dcoliversun commented on code in PR #36333:
URL: https://github.com/apache/spark/pull/36333#discussion_r858527976
##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/MountVolumesFeatureStepSuite.scala:
##########
@@ -148,6 +149,23 @@ class MountVolumesFeatureStepSuite extends SparkFunSuite {
assert(executorPVC.getClaimName.endsWith("-exec-1-pvc-0"))
}
+ test("SPARK-39006 PVC claimName must be onDemand when multiple executors") {
+ val volumeConf = KubernetesVolumeSpec(
+ "testVolume",
+ "/tmp",
+ "",
+ mountReadOnly = true,
+ KubernetesPVCVolumeConf("testClaimName")
+ )
+ val conf = new SparkConf().set(EXECUTOR_INSTANCES, 2)
+ val executorConf =
+ KubernetesTestConf.createExecutorConf(sparkConf = conf, volumes =
Seq(volumeConf))
+ val executorStep = new MountVolumesFeatureStep(executorConf)
+ assertThrows[IllegalArgumentException] {
Review Comment:
Thanks for your help. I have addressed this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
