gengliangwang commented on code in PR #36122:
URL: https://github.com/apache/spark/pull/36122#discussion_r859977600
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -3837,22 +3837,26 @@ class AstBuilder extends
SqlBaseParserBaseVisitor[AnyRef] with SQLConfHelper wit
} else {
None
}
- if (action.defaultExpression != null) {
- throw QueryParsingErrors.defaultColumnNotImplementedYetError(ctx)
- }
- if (action.dropDefault != null) {
- throw QueryParsingErrors.defaultColumnNotImplementedYetError(ctx)
- }
+ val setDefaultExpression =
+ if (action.defaultExpression != null) {
+ Option(action.defaultExpression()).map(visitDefaultExpression)
+ } else if (action.dropDefault != null) {
Review Comment:
shall we chekc if both add/drop default exist and throw an exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
