cloud-fan commented on code in PR #36330:
URL: https://github.com/apache/spark/pull/36330#discussion_r868773358
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala:
##########
@@ -41,6 +41,11 @@ private object H2Dialect extends JdbcDialect {
case _ => super.visitSQLFunction(funcName, inputs)
}
}
+
+ override def visitOverlay(inputs: Array[String]): String = {
+ val functionInfo = super.visitOverlay(inputs)
+ throw QueryCompilationErrors.noSuchFunctionError("H2", functionInfo)
Review Comment:
OK then it's a bit tricky to decide which functions should be pushed down by
default and which should not. The current policy is pushing down SQL standard
functions by default, which seems reasonable. @huaxingao do we have better
ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
