beliefer commented on code in PR #36330:
URL: https://github.com/apache/spark/pull/36330#discussion_r869102745
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala:
##########
@@ -41,6 +41,11 @@ private object H2Dialect extends JdbcDialect {
case _ => super.visitSQLFunction(funcName, inputs)
}
}
+
+ override def visitOverlay(inputs: Array[String]): String = {
+ val functionInfo = super.visitOverlay(inputs)
+ throw QueryCompilationErrors.noSuchFunctionError("H2", functionInfo)
Review Comment:
I have another idea now.
Because we already implement almost all ansi function, overlay is the only
one exception. So we push down it in default is OK too.
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala:
##########
@@ -41,6 +41,11 @@ private object H2Dialect extends JdbcDialect {
case _ => super.visitSQLFunction(funcName, inputs)
}
}
+
+ override def visitOverlay(inputs: Array[String]): String = {
+ val functionInfo = super.visitOverlay(inputs)
+ throw QueryCompilationErrors.noSuchFunctionError("H2", functionInfo)
Review Comment:
I have another idea now.
Because we already implement almost all ansi function, `overlay` is the only
one exception. So we push down it in default is OK too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
