anishshri-db commented on code in PR #36491:
URL: https://github.com/apache/spark/pull/36491#discussion_r869691484
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala:
##########
@@ -617,6 +619,7 @@ class SymmetricHashJoinStateManager(
val keyWithIndex = keyWithIndexRow(key, index)
val valuePair =
valueRowConverter.convertValue(stateStore.get(keyWithIndex))
if (valuePair == null && storeConf.skipNullsForStreamStreamJoins) {
+ skippedNullValueCount.map(_ += 1L)
Review Comment:
We also skip null values in `findNextValueForIndex` function as well:
```
private def findNextValueForIndex(): ValueAndMatchPair = {
// Loop across all values for the current key, and then all other
keys, until we find a
// value satisfying the removal condition.
def hasMoreValuesForCurrentKey = currentKey != null && index <
numValues
def hasMoreKeys = allKeyToNumValues.hasNext
while (hasMoreValuesForCurrentKey || hasMoreKeys) {
if (hasMoreValuesForCurrentKey) {
// First search the values for the current key.
val valuePair = keyWithIndexToValue.get(currentKey, index)
if (valuePair == null &&
storeConf.skipNullsForStreamStreamJoins) {
index += 1
```
Do we want to track these skips as well ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
