viirya commented on code in PR #36491:
URL: https://github.com/apache/spark/pull/36491#discussion_r869697721
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala:
##########
@@ -617,6 +619,7 @@ class SymmetricHashJoinStateManager(
val keyWithIndex = keyWithIndexRow(key, index)
val valuePair =
valueRowConverter.convertValue(stateStore.get(keyWithIndex))
if (valuePair == null && storeConf.skipNullsForStreamStreamJoins) {
+ skippedNullValueCount.map(_ += 1L)
Review Comment:
I added it in early commit, but removed it as that is for removing old
states. I think the interest is to know how many times null values are happened
during joining.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
