gengliangwang commented on code in PR #36562:
URL: https://github.com/apache/spark/pull/36562#discussion_r874474944
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/TimestampFormatterSuite.scala:
##########
@@ -456,4 +456,19 @@ class TimestampFormatterSuite extends
DatetimeFormatterSuite {
assert(errMsg.contains("""Invalid input syntax for type "TIMESTAMP":
'x123'"""))
}
}
+
+ test("default formatter: support returning optional parse results") {
Review Comment:
There are already many test cases for the timestamp inference of JSON/CSV:
https://github.com/gengliangwang/spark/runs/6451697135
Here we just add one simple test case for the default timestamp formatted
since it overrides the method `parseOptional` and `parseWithoutTimeZoneOptional`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
