cloud-fan commented on code in PR #36531:
URL: https://github.com/apache/spark/pull/36531#discussion_r874528129
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala:
##########
@@ -2138,199 +2287,28 @@ case class Cast(
final override def nodePatternsInternal(): Seq[TreePattern] = Seq(CAST)
override def canCast(from: DataType, to: DataType): Boolean = if
(ansiEnabled) {
- AnsiCast.canCast(from, to)
+ Cast.canAnsiCast(from, to)
} else {
Cast.canCast(from, to)
}
+ private val (fallbackConfKey, fallbackConfValue) =
+ if (getTagValue(Cast.TABLE_INSERTION_RESOLVER).getOrElse(false)) {
Review Comment:
can we pass a boolean flag (existence of this tag) to
`typeCheckFailureMessage` and determine the config names there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
