cloud-fan commented on code in PR #36531:
URL: https://github.com/apache/spark/pull/36531#discussion_r880662966
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/AnsiCastSuiteBase.scala:
##########
@@ -618,10 +618,14 @@ class AnsiCastSuiteWithAnsiModeOn extends
AnsiCastSuiteBase {
}
Review Comment:
I think we should clean up the test suites a bit. Now we only need to test
`Cast` and `TryCast`. `AnsiCastSuiteWithAnsiModeOn` doesn't make sense any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
